Post title: fix autofocus when iframed #51331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 0f70dc2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5210858735
|
mattwiebe
approved these changes
Jun 8, 2023
There was a problem hiding this comment.
Thanks for the quick fix!
I can confirm that this solves the problem we were seeing when loading the Post Editor inside an iframe on wordpress.com. It auto-focuses the post title on a new post as it should and doesn't produce a CORS issue when trying to access the top-level window object.
Oh and congrats on shipping the Post Editor iframe canvas! 🎉 ✨
fullofcaffeine
pushed a commit
that referenced
this pull request
Jun 8, 2023
ndiego
added
[Block] Post Title
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In #48286, I adjusted post title autofocus to check for focus in the top document, but actually this should be the parent document because the editor itself might be iframed as well.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast