Template actions with DropDownMenuV2 #51043
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +47 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in be357c90e5c0442472ed5e92e71a4a5b8f837ca6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5110234176
|
|
Thank you Nik, you anticipated my next move! I'll try to have a look at this PR today/tomorrow. Just a head-up that you may want to rebase this PR after #51046 lands, which should align the behavior of |
53 tasks
|
This is feeling really good:
As noted, it'd be nice if we could apply the 2px radius as a baseline for the visuals. Behaviorally this is feeling really strong, happy to see it. Focus management on click vs. keyboard is feeling far better too. |
Glad to hear!
Absolutely, I'm planning on working on that very soon (edit: opened #51097) |
ntsekouras
force-pushed
the
try/template-actions-with-dropdownmenu-v2
branch
from
be357c9
to
178e7e1
Compare
ciampo
reviewed
Jun 5, 2023
| @@ -64,14 +68,14 @@ export default function RenameMenuItem( { template, onClose } ) { | |||
|
|
|||
| return ( | |||
| <> | |||
| <MenuItem | |||
| <UsedComponent | |||
| onClick={ () => { | |||
There was a problem hiding this comment.
I'm not sure if onClick works at this point on DropdownMenuItemV2 — you may need to use onSelect instead (here and everywhere else in the PR)
ciampo
reviewed
Jun 5, 2023
| export default function RenameMenuItem( { | ||
| template, | ||
| onClose, | ||
| as: UsedComponent = MenuItem, |
There was a problem hiding this comment.
Any reason why we're not using DropdownMenuItemV2 directly here?
ciampo
reviewed
Jun 5, 2023
| ) } | ||
| { isRevertable && ( | ||
| <DropdownMenuItemV2 | ||
| info={ __( |
There was a problem hiding this comment.
DropdownMenuItemV2 doesn't expose an info prop — you'll have to use children and add/style that text separately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a real quick draft PR to start exploring the integration of DropDownMenuV2(see component's main issue). It's related to this issue, but I'll probably implement it with the current DropDown because we're close to 6.3 deadlines.
I'm happy to iterate on this to start pinpointing what's missing.
Testing Instructions
Templatesin site editor navigation sidebar select a custom created templaterename/delete/optionsThings noticed so far
Renameitem on click opens a Modal, but here we close the DropDown, so we cannot render it. We need to check the focus handling and what would be the best way to handle these use cases.