Handle isDraft or isInvalid Enter keypress via onKeyDown instead of a Keyboard Shortcut #51021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f keyboard shortcut
|
Size Change: -19 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
jeryj
changed the title
|
Flaky tests detected in 2df95a3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5094958497
|
jeryj
added
[a11y] Keyboard & Focus
[Block] Navigation Link
ajlende
approved these changes
May 31, 2023
ndiego
added
[Focus] Accessibility (a11y)
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…f keyboard shortcut (WordPress#51021)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes the Keyboard Shortcut for
enterand relies on theonKeyDownevent.Why?
Having a Keyboard Shortcut for
enter, meant that it captured allenterkeypresses when a draft or invalid link was on the editor, breakingenterkeypresses for anything else on the editor, even outside of the iframed editor pane in the site editor.How?
Remove the Keyboard Shortcut and add conditions to the existing
onKeyDownevent. I would have used theonClickevent, but it wasn't working. I feel like it should work withonClick, but this implementation is clearly better for now since it doesn't breakenterkeypresses across the app when there's a draft post in a navigation block.Testing Instructions for Keyboard