babel-preset-default: enable the bugfixes option for preset-env #50994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
added
[Type] Build Tooling
|
Size Change: -21.6 kB (-2%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
In addition to untranspiled function parameters, we now also get untranspiled optional chaining with |
|
Perf tests are failing because the build is broken const getGroupPlaceholderIcons = ( name = 'group' ) => {
const icons = {
group: groupMarkup
};
return icons?.[ name ];
}is now minified into: ( name = 'group' ) => { group: groupMarkup }?.[ name ]which is nonsense because the opening We'll need to upgrade Terser. |
|
Locally, upgrading Terser fixed the broken code. In minified code, I see that the object and the optional chaining are no longer inlined together: (e='group')=>{
const t = {group:groupMarkup};
return t?.[e];
}Let's see if the CI checks get fixed, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Babel has a
transform-parameterstransform plugin that transpiles all kinds of function parameters: destructuring, spread operators, ...Today all supported browsers have full ES6 support, so this transform shouldn't be active. But it is. Because Safari has an obscure bug in one destructuring edge case (https://bugs.webkit.org/show_bug.cgi?id=220517), it's not 100% safe to leave destructuring code untranspiled. That's why
transform-parametersis active by default and we get all ES6 function parameters syntax transpiled.See this screenshot where an innocent
[ key, attribute ]destructuring gets transpiled:That's why Babel has a
bugfixesoption. It replaces thetransform-parametersplugin with a more targeted one that transpiles just that one Safari edge case.Enabling this option removed all that unnecessary transpilation:
It is planned to be enabled by default in Babel 8, so it should be safe for Gutenberg, too.
Related to #50987.