Visual Editor: Refactor VisualEditor to use data query #5083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
the
General Interface
aduth
force-pushed
the
update/visual-editor-has-fixed-toolbar
branch
from
d416701 to
d6654ce
Compare
aduth
force-pushed
the
update/visual-editor-has-fixed-toolbar
branch
from
45c71c3 to
ca4974a
Compare
|
Not saying we should do it in this PR, but as a follow-up. |
|
Porting this already in #5206, going to close in favor of that one. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #5021 (comment)
This pull request seeks to refactor the
VisualEditorcomponent to use thedatamodule, largely as a demonstration of the benefits of avoiding:connectTesting instructions:
Verify there are no regressions in the behavior of the fixed toolbar.