Command Tool: Fix contextual commands selectors #50829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
|
Size Change: +3 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 6f98457. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5043778257
|
jameskoster
approved these changes
May 22, 2023
cbravobernal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #48457
What?
This PR fixes a small bug where the initial "context" persists. In other words, if you load the site editor in "edit" mode, the "revert template" command is always shown even if you leave the mode (go to view mode). The opposite is true, it's never shown if you open the editor in "view mode".
Testing Instructions
1- Have a modified saved template
2- Open the editor and check that the "revert template" command is visible when open the command center in "edit" mode but not "view" mode without refreshing the page between the mode switch.