Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grab cursor style for Block mover drag handle button #50808

Merged

Conversation

kutsu123
Copy link
Contributor

@kutsu123 kutsu123 commented May 20, 2023

What?

Add grab cursor style for Block mover drag handle button

Why?

As part #50789

How?

The cursor style specification in edit mode was missing, so a new grab style specification has been added.

Testing Instructions

  • Make sure you are in edit mode.
  • Add two arbitrary blocks.
  • Select one block and place the cursor on "drag handle".
  • Make sure the cursor is set to grab.

Testing Instructions for Keyboard

Not supported as it is not within the scope of Keyborad operation

Screenshots or screencast

screenshot_20230520_02

@kutsu123 kutsu123 requested a review from ellatrix as a code owner May 20, 2023 03:24
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label May 20, 2023
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @kutsu123! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release [Package] Block editor /packages/block-editor labels May 20, 2023
@t-hamano t-hamano self-requested a review May 20, 2023 07:07
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I believe this issue is a regression caused by the removal of cursor:glab; when the Block Mover component was cleaned up in #40379.

Thanks for your contribution!

@t-hamano t-hamano merged commit 1c0bde9 into WordPress:trunk May 20, 2023
@github-actions
Copy link

Congratulations on your first merged pull request, @kutsu123! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 15.9 milestone May 20, 2023
@kutsu123 kutsu123 deleted the fix/block_mover_drag_handle_style_grab branch May 20, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Block editor /packages/block-editor [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants