Navigation: remove all edit functionality in Browse Mode. #50788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
the
[Feature] Navigation in Site View
|
Size Change: -560 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in deb87d5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5024792273
|
3 tasks
cbravobernal
changed the title
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes all ability to add/edit Navigation items from Browse Mode.
Deliberately does not address this part of the referenced Issue as it's not clear how that should be implemented:
Part of #50698
Why?
See wider context in #50396.
The point of Browse Mode is to browse rather than edit items. You can still rearrange content but editing will not be supported at this time.
How?
Removes
Testing Instructions
Navigationin Browse Mode and make sure you cannot edit anything other than Delete and Reorder.Testing Instructions for Keyboard
Screenshots or screencast