Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wide align support to code block #50710

Merged
merged 1 commit into from
May 17, 2023
Merged

Conversation

richtabor
Copy link
Member

What?

I noticed today that there's not support for alignwide on the code block. Especially for blogs that leverage wide imagery and other content, I'd expect to also make the code block a wide width.

If so, you could achieve more expressive, and cohesive, designs like this, where everything other than text is wide width.

CleanShot 2023-05-17 at 12 11 39

Why?

Design tooling.

How?

Block.json supports.

Testing Instructions

  1. Open a Post or Page.
  2. Insert a Code block.
  3. Set it to "Wide width" via the block toolbar.

Screenshots or screencast

Before After
CleanShot 2023-05-17 at 12 01 06 CleanShot 2023-05-17 at 12 09 23

@richtabor richtabor added [Type] Enhancement A suggestion for improvement. [Block] Code Affects the Code Block labels May 17, 2023
@richtabor richtabor self-assigned this May 17, 2023
Copy link
Contributor

@cbravobernal cbravobernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cbravobernal cbravobernal merged commit 2922d6b into trunk May 17, 2023
@cbravobernal cbravobernal deleted the add/code-block-wide-align branch May 17, 2023 18:08
@github-actions github-actions bot added this to the Gutenberg 15.9 milestone May 17, 2023
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Code Affects the Code Block Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants