-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update border and focus style of the Input selector in ColorPicker Component #50703
Update border and focus style of the Input selector in ColorPicker Component #50703
Conversation
Adds backdrop to the color value type input selector in the ColorPicker component. Previously, the backdrop for this component was hidden. Fixes WordPress#50524
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @falgunihdesai! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for your patch!
I left a question about the choice of display: flex
, but otherwise this looks good to me.
I've attached a screen recording clearly showing the focus on Hex select control.
gh-50703-testing.mov
@@ -30,7 +30,7 @@ export const SelectControl = styled( InnerSelectControl )` | |||
margin-left: ${ space( -2 ) }; | |||
width: 5em; | |||
${ BackdropUI } { | |||
display: none; | |||
display: flex; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there a reason to prefer flex
over block
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used flex because other elements like Input box for color value and copy button both uses flex. Otherwise block was also working 😄. Was one of the two failed checks because of flex. Failure of Changelog diff check I understood. But the reason for another failed check is not clear to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see it, but if you saw another failure it may have been a flaky end-to-end test. Everything looks good now, so I'll merge. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the liberty of changing the display to block
and added an entry to the corresponding change log. :)
Congratulations on your first merged pull request, @falgunihdesai! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: https://profiles.wordpress.org/me/profile/edit/ And if you don't have a WordPress.org account, you can create one on this page: https://login.wordpress.org/register Kudos! |
Thanks for finding the issue and fixing it, @falgunihdesai ! |
Thank you for the help @mcsf . |
Just flagging that another PR (#50609) was also opened to fix this, in which we evaluated trade-offs between short-term fixes and design requirements |
Adds backdrop to the color value type input selector in the ColorPicker component. Previously, the backdrop for this component was hidden.
Fixes #50524
What?
Why?
How?
Testing Instructions
Run "npm storybook:dev" and select ColorPicker component. Focus the navigation tab on Color Value type dropdown selector
Testing Instructions for Keyboard
Open the Color Picker in Gutenberg editor and focus on the Color Value type dropdown selector using tab key
Screenshots or screencast