Editor canvas container: include resizeable iframe in component #50682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also making the resizable iframe optional
ramonjd
added
[Type] Enhancement
|
Size Change: -38 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
No, and thanks for checking. The commit was sitting idly on my computer because the push failed and I didn't notice 🤦 Fixed. |
andrewserong
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR moves the
<ResizableEditor enableResizing>, which wraps the<EditorCanvasContainer />fill component inpackages/edit-site/src/components/block-editor/index.js, to the fill component itself.There should be no changes to the way things look or work currently.
Why?
So that future consumers of
<EditorCanvasContainer />can decide themselves whether they want the canvas to be resizable or not.How?
Moving
<ResizableEditor enableResizing={ enableResizing }>topackages/edit-site/src/components/editor-canvas-container/index.jsand allowing resizing via the propenableResizing.Testing Instructions
In the side editor, open the style book. It should work as it does on trunk.
Update some global styles, save a couple of times. Now open revisions from the styles drop down menu. It should work as it does on trunk.
Screenshots or screencast