Combine frontend navigation Page list block tests into one test to speed up e2e tests #50681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.39 MB ℹ️ View Unchanged
|
jeryj
force-pushed
the
update/combine-fe-navigation-tests
branch
from
ba80552 to
ddc871b
Compare
jeryj
changed the title
jeryj
force-pushed
the
update/combine-fe-navigation-tests
branch
from
78b8a81 to
7b4248c
Compare
kevin940726
approved these changes
May 17, 2023
There is quite a bit of setup needed for each of the frontend navigation tests, and by combining them into one we can speed it up and follow the best practices of write fewer but longer tests: https://playwright.dev/docs/best-practices#write-fewer-tests-but-longer-tests
jeryj
force-pushed
the
update/combine-fe-navigation-tests
branch
from
7b4248c to
ca8a21d
Compare
kevin940726
reviewed
May 19, 2023
| @@ -0,0 +1 @@ | |||
| {"cookies":[{"name":"wordpress_test_cookie","value":"WP%20Cookie%20check","domain":"localhost","path":"/","expires":-1,"httpOnly":false,"secure":false,"sameSite":"Lax"},{"name":"wordpress_23778236db82f19306f247e20a353a99","value":"admin%7C1684446357%7Cdx01QADx42SHH9s4ikPkhkS07FzxnWES5FY2SsnwL7v%7C45404d74460259bc9148f2357f2180af488d65921b10ed5981fff860afa5c8ca","domain":"localhost","path":"/wp-content/plugins","expires":-1,"httpOnly":true,"secure":false,"sameSite":"Lax"},{"name":"wordpress_23778236db82f19306f247e20a353a99","value":"admin%7C1684446357%7Cdx01QADx42SHH9s4ikPkhkS07FzxnWES5FY2SsnwL7v%7C45404d74460259bc9148f2357f2180af488d65921b10ed5981fff860afa5c8ca","domain":"localhost","path":"/wp-admin","expires":-1,"httpOnly":true,"secure":false,"sameSite":"Lax"},{"name":"wordpress_logged_in_23778236db82f19306f247e20a353a99","value":"admin%7C1684446357%7Cdx01QADx42SHH9s4ikPkhkS07FzxnWES5FY2SsnwL7v%7C8ace4a8f867bc4e587d5264662296f90fcd133710cd0dd3386a92801816bd5d1","domain":"localhost","path":"/","expires":-1,"httpOnly":true,"secure":false,"sameSite":"Lax"},{"name":"wp-settings-1","value":"editor%3Dtinymce","domain":"localhost","path":"/","expires":1715809558.14,"httpOnly":false,"secure":false,"sameSite":"Lax"},{"name":"wp-settings-time-1","value":"1684273558","domain":"localhost","path":"/","expires":1715809558.14,"httpOnly":false,"secure":false,"sameSite":"Lax"}],"nonce":"fe590a7aae","rootURL":"http://localhost:8889/index.php?rest_route=/"} | |||
There was a problem hiding this comment.
I don't think this was supposed to get committed? Is this an oversight?
There was a problem hiding this comment.
Oof. Definitely not intended to be committed. I'll remove it.
cbravobernal
added
[Package] E2E Tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Combines several similar tests with repeated steps for Frontend Navigation menu tests into one test.
Why?
The setup for each test was taking awhile, and there were many repeated steps in each test. Combining them follows best practices of writing fewer but longer tests and saves quite a bit of time.
This branch's tests: 25 seconds
Same tests on trunk: 2 minutes
How?
Take the previous tests for the frontend navigation and combine them into one where it shared interactions and code.
Testing Instructions
npm run test:e2e:playwright -- editor/blocks/navigation.spec.js -g "Navigation block - Frontend interactivity"will run the test touched by this code