Create pages before navigation tests requiring link control to find page results #50680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeryj
changed the title
|
Size Change: 0 B Total Size: 1.39 MB ℹ️ View Unchanged
|
cbravobernal
added
[Package] E2E Tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Tests were failing due to the Link Control not containing any pages in its search results.
Why?
There were no pages on the site running for tests, so no pages were returned in the search API query.
How?
Before all the tests in this section, create three pages so the Link Control has pages. It's unclear to me how these were passing before.
Testing Instructions
npm run test:e2e:playwright -- editor/blocks/navigation.spec.js -g "List view editing"will run all the tests that this impacts.