-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List block: fix merging nested list into paragraph #50634
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
An existing feature does not function as intended
[Block] List
Affects the List Block
labels
May 15, 2023
mcsf
approved these changes
May 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for the super quick fix!
Size Change: +25 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
mtias
added
the
[Feature] Writing Flow
Block selection, navigation, splitting, merging, deletion...
label
May 15, 2023
Thanks for this! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] List
Affects the List Block
[Feature] Writing Flow
Block selection, navigation, splitting, merging, deletion...
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Best reviewed without whitespace changes.
Recording: backspace + undo
Why?
Nested items are lost.
How?
Fixes the list item => paragraph transform.
Note that I've also fixed the undo (by batching all actions).
Testing Instructions
See added e2e test
Testing Instructions for Keyboard
Screenshots or screencast