Use bdo element when defining the language of some text
#50632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -2 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
ellatrix
added
the
Internationalization (i18n)
ellatrix
approved these changes
May 15, 2023
|
@yoavf Could you confirm if this is good? I don't know enough to be sure. |
|
I guess what's important to know if it would do any harm. I think you can use |
|
Just raising that The second and third are correct for the text: اللغة العربية |
Thank you for raising this! I think it's OK and that should be the intended behavior... When a user selects a language, it's their responsibility to select the direction as well. So if someone selects Arabic and leaves it as LTR, then they made an error in their selection and it should be reflected in the text itself so they can reopen the popover and select the right direction. For additional context, in #49985 we experimented with automating the |
|
@senadir Worth noting that according to the spec you can't use |
|
Yeah sure thing, I think this is a small feature indirect feature that whoever is using it probably knows what they're doing. I do think that 99% of the time, you should use span, but this seems like a feature that's built for bdo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a followup to #49985
In #49985 (comment), @ellatrix suggested using the
bdoelement, so this PR does just that.Why?
Because it's the proper HTML element to use in this scenario.
How?
spantobdospanelement to differentiate it from other formatting that was also usingspan, butbdois a unique case.The implementation in #49985 was only released a few days ago and it's not used in the wild yet, so it's safe to do this NOW without the need for a deprecation.