Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin: Fix building plugin zip to include interactive blocks #50598

Merged
merged 1 commit into from
May 13, 2023

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented May 12, 2023

What?

Fixes the issue reported in the #50041 (comment):

Version 15.9.20230511 returns 404 for the following files:

vendors.min.js
interactivity.min.js
navigation.min.js

Why?

Files were missing in the gutenberg.zip file.

How?

Testing Instructions

Run npm run build:plugin-zip locally (warning: it removes all artifacts from the branch) or check one of the CI job in this branch that should have the zip file attached.

I uploaded the gutenberg.zip file to a WordPress instance and ensured that the Navigation block works correctly with the feature flag enabled:

Basically, we have to ensure that the Navigation block, the navigation submenu, and the page list behave exactly the same when the option is activated/deactivated. I used the testing instructions from #50041:

Toggle the Experimental option in Gutenberg -> Experiments:

  • Check that the mentioned experiences (and anything not mentioned) work as expected.
  • Check that it is only sending the Interactivity API scripts.
  • Change the settings of the navigation block to ensure it works fine in all cases.
  • If the Overlay menu is set to off and the "Show arrow" is set to false, the scripts shouldn't be loaded.

@gziolo gziolo added [Type] Bug An existing feature does not function as intended Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts labels May 12, 2023
@gziolo gziolo self-assigned this May 12, 2023
@gziolo gziolo requested review from ntwb, nerrad and ajitbohra as code owners May 12, 2023 15:45
@gziolo gziolo added this to the Gutenberg 15.9 milestone May 12, 2023
@gziolo gziolo added the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label May 12, 2023
@gziolo
Copy link
Member Author

gziolo commented May 12, 2023

@fabiankaegy, we must backport this bug fix to the Gutenberg 15.8 RC.

@gziolo gziolo modified the milestones: Gutenberg 15.9, Gutenberg 15.8 May 12, 2023
@gziolo gziolo merged commit 8853016 into trunk May 13, 2023
@gziolo gziolo deleted the fix/build-plugin-zip-interactive-blocks branch May 13, 2023 05:00
@fabiankaegy
Copy link
Member

I just cherry-picked this PR to the release/15.8 branch to get it included in the next release: 4871f27

@fabiankaegy fabiankaegy removed the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants