List View: Ensure settings menu is visible when focused #50572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Bug
|
Size Change: +52 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
Thanks for reviewing! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #50357
Ensure that when hovering over a focused settings menu button in the List View, that the focused state remains even when moving the mouse cursor away.
Why?
As reported in #50357, without adding a
:focus-withinrule to ensure visibility, it looks like focus is lost when mousing over the settings button.How?
:focus-withinto the visibility rule for the settings menu buttonsTesting Instructions
Testing Instructions for Keyboard
As above
Screenshots or screencast
Note that in Before the focused settings menu is unexpectedly hidden. In After, the focused settings menu state is preserved.