Add the ability to create a new page in the Site Editor #50565
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,11 +5,13 @@ import { | |
| __experimentalItemGroup as ItemGroup, | ||
| __experimentalItem as Item, | ||
| } from '@wordpress/components'; | ||
| import { useState } from '@wordpress/elements'; | ||
| import { __ } from '@wordpress/i18n'; | ||
| import { useEntityRecords } from '@wordpress/core-data'; | ||
| import { decodeEntities } from '@wordpress/html-entities'; | ||
| import { plus } from '@wordpress/icons'; | ||
| import { useDispatch } from '@wordpress/data'; | ||
| import { privateApis as routerPrivateApis } from '@wordpress/router'; | ||
|
|
||
| /** | ||
| * Internal dependencies | ||
|
|
@@ -20,6 +22,10 @@ import { useLink } from '../routes/link'; | |
| import SidebarNavigationItem from '../sidebar-navigation-item'; | ||
| import SidebarNavigationSubtitle from '../sidebar-navigation-subtitle'; | ||
| import SidebarButton from '../sidebar-button'; | ||
| import AddNewPageModal from '../add-new-page'; | ||
| import { unlock } from '../../private-apis'; | ||
|
|
||
| const { useHistory } = unlock( routerPrivateApis ); | ||
|
|
||
| const PageItem = ( { postId, ...props } ) => { | ||
| const linkInfo = useLink( { | ||
|
|
@@ -35,65 +41,85 @@ export default function SidebarNavigationScreenPages() { | |
| 'page' | ||
| ); | ||
|
|
||
| const [ showAddPage, setShowAddPage ] = useState( false ); | ||
|
|
||
| const history = useHistory(); | ||
| const { setPage } = unlock( useDispatch( editSiteStore ) ); | ||
|
|
||
| const handleNewPage = ( { type, id } ) => { | ||
| setPage( { | ||
| context: { postType: type, postId: id }, | ||
| } ); | ||
SaxonF marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| // Navigate to the created template editor. | ||
| history.push( { | ||
SaxonF marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| postId: id, | ||
| postType: type, | ||
| canvas: 'edit', | ||
| } ); | ||
| setShowAddPage( false ); | ||
| }; | ||
|
|
||
| return ( | ||
| <> | ||
| { showAddPage && ( | ||
| <AddNewPageModal | ||
| onSave={ handleNewPage } | ||
| onCancel={ () => setShowAddPage( false ) } | ||
SaxonF marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| /> | ||
| ) } | ||
| <SidebarNavigationScreen | ||
| title={ __( 'Pages' ) } | ||
| description={ __( 'Browse and edit pages on your site.' ) } | ||
| actions={ | ||
| <SidebarButton | ||
| icon={ plus } | ||
| label={ __( 'Draft a new page' ) } | ||
| onClick={ () => setShowAddPage( true ) } | ||
| /> | ||
| } | ||
| content={ | ||
| <> | ||
| { isLoading && ( | ||
| <ItemGroup> | ||
| <Item>{ __( 'Loading pages' ) }</Item> | ||
| </ItemGroup> | ||
| ) } | ||
| { ! isLoading && ( | ||
| <> | ||
| <SidebarNavigationSubtitle> | ||
| { __( 'Recent' ) } | ||
| </SidebarNavigationSubtitle> | ||
| <ItemGroup> | ||
| { ! pages?.length && ( | ||
| <Item>{ __( 'No page found' ) }</Item> | ||
| ) } | ||
| { pages?.map( ( page ) => ( | ||
| <PageItem | ||
| postId={ page.id } | ||
| key={ page.id } | ||
| withChevron | ||
| > | ||
| { decodeEntities( | ||
| page.title?.rendered | ||
| ) ?? __( '(no title)' ) } | ||
|
There was a problem hiding this comment. If the page title is an empty string this will return an empty string rather than There was a problem hiding this comment. @scruffian I think this is something we can address in this issue as its more directly related to the pages list |
||
| </PageItem> | ||
| ) ) } | ||
| <SidebarNavigationItem | ||
| className="edit-site-sidebar-navigation-screen-pages__see-all" | ||
| href="edit.php?post_type=page" | ||
| onClick={ () => { | ||
| document.location = | ||
SaxonF marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| 'edit.php?post_type=page'; | ||
| } } | ||
| > | ||
| { __( 'Manage all pages' ) } | ||
| </SidebarNavigationItem> | ||
| </ItemGroup> | ||
| </> | ||
| ) } | ||
| </> | ||
| } | ||
| /> | ||
| </> | ||
| ); | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the page is created, where should focus get placed? Right now it's being dropped at the hidden Back button in the closed sidebar. I agree with @carolinan that the current mode of being moved to the site editor template for this page is an odd experience. I'd be fine with it if the sidebar stayed open, in which case, handling the focus here isn't an issue since it's being placed in a sensible spot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will make more sense once the content editing PR is merged. There is also some follow up work around improving the add page experience, including selecting starter patterns.