[RNMobile] Test Helpers: Provide onPickerButtonPressed arg to setupPicker helper
#50493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The onManualTrigger arg is optional, and necessary for times when the picker is manually triggered via a user event.
This change is necessary now that the selectOption function is async.
|
Size Change: +3.5 kB (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
SiobhyB
changed the title
setupPicker test helper function for iOS
|
Flaky tests detected in a9ee3c7. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4938177806
|
2 tasks
SiobhyB
added
the
Mobile App - i.e. Android or iOS
SiobhyB
changed the title
setupPicker test helper function for iOSsetupPicker helper function
|
SiobhyB
pushed a commit
to wordpress-mobile/gutenberg-mobile
that referenced
this pull request
May 10, 2023
This commit pulls in the changes from this PR, which are needed to use the picker in our tests: WordPress/gutenberg#50493
SiobhyB
changed the title
setupPicker helper functiononPickerButtonPressed arg to setupPicker helper
2 tasks
@SiobhyB following this comment, I'm not sure if we really need this change to test the picker. Could you share an example of the issue you were having? Thanks! |
|
Closing, as discussed in wordpress-mobile/gutenberg-mobile#5754 (comment). |
fluiddot
deleted the
rnmobile/add/optional-manual-trigger-arg-setup-picker
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds an optional
onPickerButtonPressedcallback to thesetupPickerhelper function, allowing easier testing on iOS for components likeSelectControl, which display a native iOS action sheet only when pressed.Why?
In certain test cases for iOS, the picker is only displayed after manually pressing a button, for example in
SelectControl. Attempting to usesetupPickerin these cases doesn't work as expected out-of-the-box due to timeout issues.By providing an
onPickerButtonPressedcallback, we can avoid timeout issues and more accurately simulate user interaction.How?
The
setupPickerfunction now accepts an optional third argument,onPickerButtonPressed, which defaults to an empty function. By awaiting theonPickerButtonPressedfunction, we ensure that any required setup or interaction occurs before the picker is displayed.Testing Instructions
setupPickerhelper on iOS.successfully uploads itemsGallery test. Apply the following patch to isolate that test:After applying the above patch, run the
TEST_RN_PLATFORM=ios npm run native test -- gallery/test/indexcommand in the terminal to verify it still passes following the changes in this PR.Verify that it's possible to successfully pass the new argument to the helper. An example of this being used be found in VideoPress block: Add tests to verify Privacy and Rating settings wordpress-mobile/gutenberg-mobile#5754.