DimensionControl: Use WordPress package instead of react in code example #50435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
commented
May 8, 2023
packages/components/CHANGELOG.md
Outdated
| @@ -21,6 +21,7 @@ | |||
| - `ToolbarItem`: Convert to TypeScript ([#49190](https://github.com/WordPress/gutenberg/pull/49190)). | |||
| - Move rich-text related types to the rich-text package ([#49651](https://github.com/WordPress/gutenberg/pull/49651)). | |||
| - `SlotFill`: simplified the implementation and removed unused code ([#50098](https://github.com/WordPress/gutenberg/pull/50098) and [#50133](https://github.com/WordPress/gutenberg/pull/50133)). | |||
| - `DimensionControl`: Use WordPress package instead of react in code example ([#50435](https://github.com/WordPress/gutenberg/pull/50435)). | |||
There was a problem hiding this comment.
Since this is just a comment update, I added a CHANGELOG to the Internal section.
There was a problem hiding this comment.
Would the "Documentation" section fit better?
|
Flaky tests detected in 88307e0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4927194040
|
mirka
approved these changes
May 9, 2023
packages/components/CHANGELOG.md
Outdated
| @@ -21,6 +21,7 @@ | |||
| - `ToolbarItem`: Convert to TypeScript ([#49190](https://github.com/WordPress/gutenberg/pull/49190)). | |||
| - Move rich-text related types to the rich-text package ([#49651](https://github.com/WordPress/gutenberg/pull/49651)). | |||
| - `SlotFill`: simplified the implementation and removed unused code ([#50098](https://github.com/WordPress/gutenberg/pull/50098) and [#50133](https://github.com/WordPress/gutenberg/pull/50133)). | |||
| - `DimensionControl`: Use WordPress package instead of react in code example ([#50435](https://github.com/WordPress/gutenberg/pull/50435)). | |||
There was a problem hiding this comment.
Would the "Documentation" section fit better?
|
Thanks for the review, @mirka! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR rewrites
useStateto import from@wordpress/elementinstead ofreactin the code example. At the same time, I have rearranged the order according to the README usage.Testing Instructions
There is no impact on the code.