Remove the loader from sidebar navigation screen. #50326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
Mamaduka
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves #50224.
Removing the navigation loader as per #50224
Why?
It was reported that the navigation loader was flashing in, and it wasn't following the design patterns of other loaders. I'm removing the code, as it was also reported to be triggered when navigating back and forth, and it wasn't ideal. I could adjust the PR to re-introduce the loader component but empty if that's a better approach for future development (Although, I think having an empty placeholder wouldn't be ideal at this stage).
Testing Instructions
Screenshots or screencast
Screen.Recording.2023-05-04.at.13.36.15.mov