Migrate Adding Patterns Test to Playwright #50083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pooja-muchandikar
requested review from
kevin940726,
ntwb,
nerrad and
ajitbohra
as code owners
kevin940726
approved these changes
Apr 26, 2023
| await expect.poll( editor.getBlocks ).toMatchObject( [ | ||
| { | ||
| name: 'core/social-links', | ||
| attributes: { className: 'has-icon-color' }, |
There was a problem hiding this comment.
Nit: I don't think we need this. I think we only want to check if it's a social-links block.
Suggested change
| attributes: { className: 'has-icon-color' }, |
There was a problem hiding this comment.
Addressed the feedback!
|
Hi @kevin940726, Thanks for the suggestions, I have addressed those but seems like the CI is failing but its not due to my test case, but its failing for
Thanks! |
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851.
Migrate adding-patterns.test.js to its Playwright version.
Why?
Part of #38851.
How?
See MIGRATION.md for migration steps.
Testing Instructions
Run
npm run test:e2e:playwright test/e2e/specs/editor/various/adding-patterns.spec.js