-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace fallbacks to fallback (singular) in Nav fallback REST endpoint #50044
Merged
getdave
merged 1 commit into
trunk
from
update/rename-nav-fallback-endpoint-to-singular
Apr 26, 2023
Merged
Replace fallbacks to fallback (singular) in Nav fallback REST endpoint #50044
getdave
merged 1 commit into
trunk
from
update/rename-nav-fallback-endpoint-to-singular
Apr 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
requested review from
TimothyBJacobs and
tellthemachines
as code owners
April 24, 2023 17:44
Thanks @getdave! |
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
draganescu
approved these changes
Apr 25, 2023
bph
added
REST API Interaction
Related to REST API
[Type] Bug
An existing feature does not function as intended
labels
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
REST API Interaction
Related to REST API
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Renames endpoint from
navigation-fallbacks
tonavigation-fallback
.Fixes #49997
Why?
Because it's not a collection-based endpoint. See Issue.
How?
Search and replace.
Testing Instructions
Check tests pass.
Testing Instructions for Keyboard
Screenshots or screencast