-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wp-env: Improve run command execution speed #50007
Conversation
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does what it says on the tin @noahtallen.
How would you feel about sleep infinity
instead of the tail
? I think it might eat less CPU cycles because it's on a permanent interrupt?
As an aside, once #49962 is merged, we can actually do this in the CLI container's Dockerfile:
CMD [ "sleep", "infinity" ]
Depending on which of these is merged first, we can make a change accordingly?
Seems like a good idea! I copied the |
e37d1e2
to
c11312a
Compare
What?
Resolves #49168 -- makes
wp-env run
a lot faster by executing commands against existing services rather than starting new services from scratch. (And makes wp-env cli persist)Why?
Faster is better :)
How?
Changes from using
docker-compose run
todocker-compose exec
. Run creates new containers from scratch each time. We also make more services persistent. This means that the startup cost happens during wp-env run, but not during subsequent executions.Testing Instructions
npx wp-env run cli ...
and other permutations of wp-env run locally.