Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style book: make the style book slot generic #49973

Merged
merged 7 commits into from
Apr 26, 2023
Merged

Style book: make the style book slot generic #49973

merged 7 commits into from
Apr 26, 2023

Commits on Apr 23, 2023

  1. Initial commit: 

    - create new component slot to house style book and other editor views
    @ramonjd
    ramonjd committed Apr 23, 2023
    Configuration menu
    Copy the full SHA
    5029e87 View commit details
    Browse the repository at this point in the history

  2. - adding state for editor canvas view container 

    - forwarding refs to first child
    @ramonjd
    ramonjd committed Apr 23, 2023
    Configuration menu
    Copy the full SHA
    b366e0e View commit details
    Browse the repository at this point in the history

  3. - attempting to juggle refs so that we retain keyboard navigation and… 

    … close functionality
    @ramonjd
    ramonjd committed Apr 23, 2023
    Configuration menu
    Copy the full SHA
    7feeed1 View commit details
    Browse the repository at this point in the history

  4. Remove comment that was the motivation behind this PR in the first pl… 

    …ace.
    @ramonjd
    ramonjd committed Apr 23, 2023
    Configuration menu
    Copy the full SHA
    2fae441 View commit details
    Browse the repository at this point in the history

  5. Adding the label to the interactive element

    @ramonjd
    ramonjd committed Apr 23, 2023
    Configuration menu
    Copy the full SHA
    848d03c View commit details
    Browse the repository at this point in the history

  6. Make the slot private.

    @ramonjd
    ramonjd committed Apr 23, 2023
    Configuration menu
    Copy the full SHA
    b2a2a70 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2023

  1. Resetting default state of editorCanvasContainerView to undefined

    @ramonjd
    ramonjd committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    4fbb2d1 View commit details
    Browse the repository at this point in the history