[WIP] Initial attempt to leave a pattern block wrapped around a pattern #49967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.08 kB (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in e9e9308. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4856952236
|
kevin940726
reviewed
Apr 25, 2023
|
@aaronrobertshaw this change seems to fix the duplicated block controls issue |
… appear on pattern block (#50118) --------- Co-authored-by: Aaron Robertshaw <[email protected]>
…ning the inner blocks
glendaviesnz
force-pushed
the
try/wrapping-patterns-in-pattern-block
branch
from
60edbdf to
f4105c7
Compare
kevin940726
reviewed
May 2, 2023
| @@ -6,13 +6,29 @@ | |||
| "category": "theme", | |||
| "description": "Show a block pattern.", | |||
| "supports": { | |||
| "html": false, | |||
| "inserter": false | |||
There was a problem hiding this comment.
Curious to know why we want to allow the pattern block to be shown in the inserter? Moreover, should it be allowed to create a pattern block without the slug attribute? What's the difference between it and a group block?
|
Closing this in favour of one that focuses on just adding the patterns wrapper and will circle back on the syncing options later after that is in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Experimenting with leaving a Pattern block wrapper around a pattern
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast