Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match Container's User and Group to Host #49962

Merged
merged 20 commits into from
Apr 28, 2023
Merged

Match Container's User and Group to Host #49962

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
b61c0ef
Changed Environment Container User
ObliviousHarmony Apr 20, 2023
027a071
Changelog
ObliviousHarmony Apr 20, 2023
cdaf544
Create Group When It Doesn't Exist
ObliviousHarmony Apr 20, 2023
6c02538
Marked Breaking Change
ObliviousHarmony Apr 20, 2023
97c23c5
Moved `getHostUser()` To Dedicated File
ObliviousHarmony Apr 20, 2023
63f1144
Merge branch 'trunk' into try/env-container-ownership
ObliviousHarmony Apr 20, 2023
bd9164a
Removed Upload Permission Mod
ObliviousHarmony Apr 21, 2023
3ffa6f4
Added Shared Home Directory
ObliviousHarmony Apr 21, 2023
269b574
Fixed Dangling Containers
ObliviousHarmony Apr 21, 2023
2c2347f
Isolated Docker Service Images
ObliviousHarmony Apr 22, 2023
9b9edda
Removed Some Duplication
ObliviousHarmony Apr 25, 2023
8ddef45
Added Destroy Note To Changelog
ObliviousHarmony Apr 25, 2023
d252b8b
Documented getHostUser Windows Handling
ObliviousHarmony Apr 25, 2023
3867a1d
Update packages/env/CHANGELOG.md
ObliviousHarmony Apr 27, 2023
27eaca1
Fixed Debian Stretch Repositories
ObliviousHarmony Apr 27, 2023
9cd128e
Updated Documentation
ObliviousHarmony Apr 27, 2023
3a4146a
Added Debian Stretch Archive List Link
ObliviousHarmony Apr 27, 2023
aab3e3d
Merge branch 'trunk' into try/env-container-ownership
ObliviousHarmony Apr 27, 2023
5d9f976
Moved CLI Sleep Into Dockerfile
ObliviousHarmony Apr 27, 2023
3424a05
Update CHANGELOG.md
noahtallen Apr 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/env/lib/init-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,14 @@ function wordpressDockerFileContents( image, config ) {

return `FROM ${ image }

# Update apt sources for archived versions of Debian.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might also add a comment linking to that stack overflow thread for a bit of extra context

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a bad idea. Given that it's a better source of truth, I've instead linked to the Debian mailing list record of the change.


# stretch
RUN sed -i 's|deb.debian.org/debian stretch|archive.debian.org/debian stretch|g' /etc/apt/sources.list
RUN sed -i 's|security.debian.org/debian-security stretch|archive.debian.org/debian-security stretch|g' /etc/apt/sources.list
RUN sed -i '/stretch-updates/d' /etc/apt/sources.list

# Prepare dependencies
RUN apt-get -qy install $PHPIZE_DEPS && touch /usr/local/etc/php/php.ini
${ shouldInstallXdebug ? installXdebug( config.xdebug ) : '' }

Expand All @@ -215,7 +223,7 @@ RUN groupadd -g $HOST_GID $HOST_USERNAME || true
RUN useradd -m -u $HOST_UID -g $HOST_GID $HOST_USERNAME || true

# Set up sudo so they can have root access when using 'run' commands.
RUN apt-get update
RUN apt-get update -qy
RUN apt-get -qy install sudo
RUN echo "$HOST_USERNAME ALL=(ALL) NOPASSWD:ALL" >> /etc/sudoers
`;
Expand Down