Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak WordPressComponent type #49960

Merged
merged 2 commits into from
Apr 21, 2023
Merged

Tweak WordPressComponent type #49960

merged 2 commits into from
Apr 21, 2023

Conversation

mirka
Copy link
Member

@mirka mirka commented Apr 20, 2023

Partially addresses #49736 (comment)
Follow-up to #43610 (comment)

What?

Tweaks the selector property of the WordPressComponent to be optional.

Why?

The way we were suppressing this problem with a @ts-expect-error is causing issues in the built .d.ts file.

Testing Instructions

✅ Types build without errors

@mirka mirka added the [Package] Components /packages/components label Apr 20, 2023
@mirka mirka self-assigned this Apr 20, 2023
@mirka mirka requested a review from ajitbohra as a code owner April 20, 2023 15:00
@mirka mirka requested review from ciampo, noahtallen and chad1008 April 20, 2023 15:55
chad1008
chad1008 approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@chad1008 chad1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 🚢

@noahtallen noahtallen mentioned this pull request Apr 21, 2023
Open
@mirka mirka merged commit a47a09e into trunk Apr 21, 2023
@mirka mirka deleted the types/wordpress-component branch April 21, 2023 07:12
@github-actions github-actions bot added this to the Gutenberg 15.7 milestone Apr 21, 2023
@bph bph added the [Type] Bug An existing feature does not function as intended label Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chad1008 chad1008 chad1008 approved these changes

@noahtallen noahtallen noahtallen approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ciampo ciampo Awaiting requested review from ciampo

Assignees

@mirka mirka

Labels
[Package] Components /packages/components [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 15.7
Development

Successfully merging this pull request may close these issues.
4 participants
@mirka @noahtallen @chad1008 @bph