-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for variations
key in theme.json
#49826
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reads well to me, just left a tiny grammatical nit, but feel free to ignore it.
Thanks for updating the docs! ✨
Today I have had more time to test whether it works with block style variations added from themes and plugins.
When testing variations in theme.json with the theme-registered custom styles, I even get PHP warnings. The PHP warnings and the limitation is not relevant for this PR other than making sure that the documentation explains that only core block style variations work. |
Thanks @carolinan for the context. I pushed 1f2098d for clarification and tested that block variations defined via |
@carolinan I almost forgot to mention that #49807 will fix the error for Gutenberg when an unregistered style variation is used in the |
Follow-up to #46343
What?
This PR adds docs for the
variations
key added totheme.json
in WordPress 6.2.Why?
We should aim to document every aspect of the
theme.json
specification, so it's clear to extenders.How?
By adding the respective section to the
theme.json
how-to docs.Testing
Inspect the new section and proofread.
Read it as part of the whole document.