Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Explore replacing RichText footnotes on the server #49760

Closed
wants to merge 1 commit into from

Conversation

dmsnell
Copy link
Member

@dmsnell dmsnell commented Apr 12, 2023

Given a post_content with <data value="core/footnote">[Some reference]</data> this replaces on render that content with a link to a later footnote at the end of the post, then appends a list of footnotes at the end of the post.

Borrows code directly from #47682

This is silly code, please DO NOT MERGE.

Screenshot 2023-04-12 at 5 07 00 PM

Screenshot 2023-04-12 at 5 07 04 PM

Screenshot 2023-04-12 at 5 07 12 PM

@dmsnell dmsnell requested a review from ellatrix April 12, 2023 15:11
@github-actions
Copy link

Flaky tests detected in 222db00.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4679919331
📝 Reported issues:

@ellatrix
Copy link
Member

Cherry picked your commit into #49797

@dmsnell
Copy link
Member Author

dmsnell commented May 4, 2023

@ellatrix I'm closing this because I think it's no longer needed

@dmsnell dmsnell closed this May 4, 2023
@dmsnell dmsnell deleted the explore/replace-footnotes-on-server branch May 4, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants