[RNMobile] Add viewport optional props #49696
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
|
Flaky tests detected in a2439da. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4660200504
|
jhnstn
commented
Apr 10, 2023
| @@ -98,7 +98,6 @@ const observeAndResizeJS = ` | |||
| // get an DOM mutations for that, so do the resize when the window is resized, too. | |||
| window.addEventListener( 'resize', sendResize, true ); | |||
| window.addEventListener( 'orientationchange', sendResize, true ); | |||
| widow.addEventListener( 'click', sendResize, true ); | |||
There was a problem hiding this comment.
see #49663 (comment)
jhnstn
commented
Apr 10, 2023
| @@ -215,7 +215,7 @@ function Sandbox( { | |||
| <title>{ title }</title> | |||
| <meta | |||
| name="viewport" | |||
| content="width=device-width, initial-scale=1" | |||
| content={ `width=device-width, initial-scale=1, ${ viewportProps }` } | |||
There was a problem hiding this comment.
I verified that an extra comma is fine in the case where someone prefixes viewportProps with a comma like ", user-scalable=0"
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a the
viewportPropsprop to theSandboxcomponent.Why?
There are cases where the owner of a
Sandboxneeds to control the html viewport.How?
Adds a prop to the
Sandboxthat is added to the default viewport settings.Testing Instructions
Verify the change does not introduce any regression issues.
Feature testing is TBD
Testing Instructions for Keyboard
Screenshots or screencast