-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fallback not rendering #49576
Fix fallback not rendering #49576
Conversation
Flaky tests detected in 7ed8a81. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4606794317
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tests well and looking at the reverted PR the code makes sense to me
I just cherry-picked this PR to the release/15.5 branch to get it included in the next release: 3180818 |
* remove useless check for empty fallback navigation * remove useless check for empty fallback navigation
Is there a way to cover this with a test? |
What?
Removes a useless check for empty fallback meny blocks.
Why?
#48602 which reverted #47684 failed to remove the code at 8548085#diff-90cb5b64c95087ded3c7bb160e38189c8499b0f14f61beb884c887452449fa12R495
This code now prevents fallnack page list navigation from rendering on the front end.
How?
Remove the left over check for empty blocks. It only makes sense in the if branch before, where
$maybe_fallback
may be empty because ofblock_core_navigation_filter_out_empty_blocks
.Testing Instructions
wp-admin/edit.php?post_type=wp_navigation
)