Image: Display custom borders on placeholder #49569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Enhancement
|
Size Change: +440 B (0%) Total Size: 1.35 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 6c2ad77. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4613608871
|
apeatling
approved these changes
Apr 18, 2023
There was a problem hiding this comment.
✅ Followed the instructions and everything checked out and worked as expected.
Global styles set border on deselected image, and not on selected image with placeholder:
Custom border set on image shown when deselected, and not when selected:
Global styles based and block custom border working correctly when image set:
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #49144
Related:
What?
Applies custom borders from either Global Styles or individual border block supports to the Image block's placeholder when it isn't selected.
Why?
This brings the Image block more in line with the Post Featured Image block which displays borders on its placeholder.
How?
Testing Instructions
Screenshots or screencast
Screen.Recording.2023-04-04.at.6.15.25.pm.mp4