Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update e2e test device documentation #49441

Merged
merged 3 commits into from
Mar 29, 2023

Conversation

dcalhoun
Copy link
Member

What?

Document visual regression testing emulator/simulator requirements.

Why?

Using devices and OS versions that differ from the CI configuration cause false
failures for visual regression tests that rely upon snapshot images.

How?

Document the importance of device and OS version for visual regression tests.

Testing Instructions

n/a

Testing Instructions for Keyboard

n/a

Screenshots or screencast

n/a

@dcalhoun dcalhoun added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Mar 29, 2023
@dcalhoun dcalhoun self-assigned this Mar 29, 2023
@dcalhoun dcalhoun force-pushed the docs/update-e2e-test-device-documentation branch from a01527d to 5442034 Compare March 29, 2023 13:03
Specific emulators/simulators are required to avoid false failures
resulting from subtle OS differences.
@dcalhoun dcalhoun force-pushed the docs/update-e2e-test-device-documentation branch from 5442034 to 8d90461 Compare March 29, 2023 13:05
@dcalhoun dcalhoun marked this pull request as ready for review March 29, 2023 13:13
@dcalhoun dcalhoun enabled auto-merge (squash) March 29, 2023 13:13
@dcalhoun dcalhoun requested a review from geriux March 29, 2023 13:13
Copy link
Member

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for updating the docs! 🚀

@dcalhoun dcalhoun merged commit 8400eff into trunk Mar 29, 2023
@dcalhoun dcalhoun deleted the docs/update-e2e-test-device-documentation branch March 29, 2023 14:09
@github-actions github-actions bot added this to the Gutenberg 15.5 milestone Mar 29, 2023
@ryanwelcher ryanwelcher added the [Type] Developer Documentation Documentation for developers label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants