Fix sprintf() arguments

[janboddez]

Argnum dollar sign seemed to be missing. The 2 in %2s is really a width argument.

What?

Unless the 2nd and 3rd sprintf() arguments (both referenced using %2s) in this line of code really need to have a width of at least 2 chars, there's a typo here, and %2$s and %3$s were meant (and %1$s where %1s was used). See also https://www.php.net/manual/en/function.sprintf.php (compare the argnum$ and width arguments).

Why?

In this case, the bug is mostly harmless, as link targets or author names will almost always have a length of more than 2. Meaning %2s is equivalent to %s and no padding will take place.

But the code is confusing, because it really looks like %2$s was meant instead. It kind of looks like there are more such occurrences in WordPress' code, too, but lets start small.

How?

Added missing dollar sign, fixed 3rd sprintf arg.

Testing Instructions

For most (all?) practical cases, there will be no change in output. But using, e.g., %3s is confusing and may lead to errors in other situations (where %3$s was meant instead), if the argument order is ever changed (like in translated strings).

[github-actions]

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @janboddez! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

[janboddez]

Cf. also the post-author-name block, which does get it right:

gutenberg/packages/block-library/src/post-author-name/index.php

Line 28 in 57fe118

$author_name = sprintf( '<a href="%1$s" target="%2$s" class="wp-block-post-author-name__link">%3$s</a>', get_author_posts_url( $author_id ), esc_attr( $attributes['linkTarget'] ), $author_name );

[Mamaduka]

Thank you, @janboddez!

[github-actions]

Congratulations on your first merged pull request, @janboddez! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!