POC Slot/Fill Ordering #49401
Draft
POC Slot/Fill Ordering #49401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a <Fill /> for a <Slot />, you can pass the priority (defaults to 10 if none passed) in order to output the fills in a more determinisitic order.
|
Size Change: +6.72 kB (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in b721bb6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4774530944
|
This utilizes the priority ordering added for fills in the previous commit(s) as a POC and to allow plugins to have more flexibility in where they add items into the post status info sidebar.
|
It would be great to see this issue resolved! Recently I had to use odd hacks for a workaround. Some interesting ideas were shared during a previous attempt to fix the problem - #29287 (comment). |
|
Taking notes for my future self: it looks like the |
|
More notes on context and ideas about reordering fills, and maybe not using bubblesVirtually at all: #19242 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POC attempt at fixing #15641
What?
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast