Use immutableSet utility to set style properties #49365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Code Quality
youknowriad
commented
Mar 27, 2023
| * @param {*} value New value to set. | ||
| * @return {Object} Cloned object with the new value set. | ||
| */ | ||
| export function immutableSet( object, path, value ) { |
There was a problem hiding this comment.
I didn't make any change to the utility, I just moved it to a better place (utils for the whole package and not just hooks)
|
Size Change: -235 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
Going to merge this as a small non impactful refactoring. |
I haven't been able to go through the entire PR (at a meetup this week), but this looks like a nice improvement, thanks 👍 |
|
I think this PR might have introduced an error in global styles when adjusting padding values at the root level. I have a fix over in #49465 — I didn't look closely at this code, but just fixed the error that's failing, so there could be a better way to go about it. Feel free to close that PR if there's a better fix! |
mcsf
reviewed
Apr 19, 2023
| * @param {*} value New value to set. | ||
| * @return {Object} Cloned object with the new value set. | ||
| */ | ||
| export function immutableSet( object, path, value ) { |
There was a problem hiding this comment.
I found this name super confusing because it sounds like a constructor for a kind of Set that is immutable (e.g. frozenset). The docstring is also confusing.
Alternative names: setImmutably, immutablySet.
Alternative description: Immutably sets a value inside an object. Like lodash#set, but returning a new object.
mcsf
added a commit
that referenced
this pull request
Apr 24, 2023
mcsf
added a commit
that referenced
this pull request
Apr 26, 2023
* Block Editor: Rename immutableSet to setImmutably Addresses #49365 (comment) * Add breaking change to CHANGELOG.md
|
Hi @youknowriad Is it possible this PR introduced a bug where all global settings are saved in global styles when updating the site layout in the dimensions panel? Please see here: #53868 |
|
@Andrew-Starr I've been able to reproduce the issue, I'll take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I discovered recently that we have an
immutableSetutility in the block-editor package, I'm just updating some existing code in global styles panels to use the utility instead of the nested spread approach that can be hard to read.Testing Instructions
Nothing really to test as the changes are straightforward but you could try to apply styles to several blocks.