Make grid layout Group variation an experiment. #49359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
requested review from
spacedmonkey and
ajitbohra
as code owners
|
Size Change: +46 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 6d0d6e4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4528138444
|
andrewserong
approved these changes
Mar 27, 2023
There was a problem hiding this comment.
Thanks for getting this PR up so quickly! It's testing very well:
✅ Opening a post or page that already contains a Grid block (prior to this PR) works correctly and I can continue to edit and make changes to the block
✅ The checkbox in the experiments settings page reads well
✅ With the check enabled the Grid block is discoverable / insertable, and the variation can be seen and picked in the top right of the inspector panel
| Experiment switched off | Experiment switched on |
|---|---|
 |
 |
LGTM! ✨
optional chaining for window Co-authored-by: Andrew Serong <[email protected]>
tellthemachines
added
the
[Feature] Layout
ryanwelcher
added
[Block] Group
|
Missing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow-up to #49018. Puts the new Group variation introduced in that PR behind a feature flag for now.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast