Image: Don't create an external image 'blob' when a user can't upload files #49300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
requested review from
ntsekouras and
ellatrix
and removed request for
ajitbohra
Mamaduka
added
[Type] Bug
|
Size Change: +14 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 03beb71. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4499547562
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #46326.
PR update external image fetching side-effect to check if a user can upload media.
Why?
upload_filescapability.externalBlobhas no value.Testing Instructions
I'm using an image from Openverse since they rarely trigger CORS errors. Sample - https://openverse.org/image/dbc5280c-a61b-43c2-9f3d-c29302897434.
The feature will work for users with the right capabilities as before.
Screenshots or screencast