CircularOptionPicker: force swatches to visually render on top of the rest of the component's content #49245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e component's content
ciampo
added
[Type] Bug
|
Size Change: +182 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Mar 22, 2023
|
Good point — I updated the code to use that same |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #49225
Make sure that the swatches wrapper in the
CircularOptionPickercomponent renders on top of the rest of the component's content.This, intrinsically, makes sure that tooltips rendered when hovering/focusing the picker options also render on top of any other UI.
Why?
This change fixes UI issues like experienced in #49225
How?
By adding explicit CSS rules to force the swatch container to have a higher z-index than its following siblings.
Testing Instructions
DuotonePickerexampleCheck for potential regressions across usages of the
CircularOptionPickerin the editorScreenshots or screencast
trunk)