Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block patterns: use WP_Theme_JSON_Resolver_Gutenberg instead of WP_Theme_JSON_Resolver #49197

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Block patterns: use WP_Theme_JSON_Resolver_Gutenberg instead of WP_Theme_JSON_Resolver #49197

merged 1 commit into from
Mar 20, 2023

Conversation

oandregal
Copy link
Member

What?

This PR updates the block pattern to use the gutenberg class instead of the respective core class.

Why?

As these classes still live in Gutenberg and can receive updates, we need to use them in the plugin.

Testing Instructions

  • Insert a Heading block
  • Open the block switcher menu
  • Observe that there is a pattern suggested, coming from Pattern Directory

@oandregal oandregal requested a review from spacedmonkey as a code owner March 20, 2023 10:48
@oandregal oandregal self-assigned this Mar 20, 2023
@oandregal oandregal added the [Type] Code Quality Issues or PRs that relate to code quality label Mar 20, 2023
@oandregal oandregal mentioned this pull request Mar 20, 2023
Merged
aristath
aristath approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@aristath aristath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and makes perfect sense 👍

@oandregal oandregal changed the title Use WP_Theme_JSON_Resolver_Gutenberg instead of WP_Theme_JSON_Resolver block patterns: use WP_Theme_JSON_Resolver_Gutenberg instead of WP_Theme_JSON_Resolver Mar 20, 2023
@oandregal oandregal added [Type] Bug An existing feature does not function as intended and removed [Type] Code Quality Issues or PRs that relate to code quality labels Mar 20, 2023
@oandregal oandregal changed the title block patterns: use WP_Theme_JSON_Resolver_Gutenberg instead of WP_Theme_JSON_Resolver Block patterns: use WP_Theme_JSON_Resolver_Gutenberg instead of WP_Theme_JSON_Resolver Mar 20, 2023
@github-actions
Copy link

Flaky tests detected in fcb0525.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4467339696
📝 Reported issues:

ntsekouras
ntsekouras approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@ntsekouras ntsekouras merged commit c8a74a9 into trunk Mar 20, 2023
@ntsekouras ntsekouras deleted the fix/use-core-class-in-block-patterns branch March 20, 2023 11:26
@github-actions github-actions bot added this to the Gutenberg 15.5 milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntsekouras ntsekouras ntsekouras approved these changes

@aristath aristath aristath approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

@Mamaduka Mamaduka Awaiting requested review from Mamaduka

@carolinan carolinan Awaiting requested review from carolinan

Assignees

@oandregal oandregal

Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 15.5
Development

Successfully merging this pull request may close these issues.
3 participants
@oandregal @aristath @ntsekouras