Post Excerpt Block: Fix unexpected commas in certain site languages #49123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
Internationalization (i18n)
|
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
mcsf
approved these changes
Mar 20, 2023
|
Thanks, @t-hamano! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #49121
What?
This PR fixes an unexpected comma in the excerpt block when the word count type for that site language is
characters_including_spaces.Why?
This is because the
join(), which concatenates array elements and converts them to a string, was missing during the word count above.Testing Instructions
最大単語数.) also works as expected.Before
befre.mp4
After
after.mp4