Fix running performance tests locally via CLI #49068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +294 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
2509edd fixes the issue where the branch name is not sanitized and breaks the path or filename it's used in, ultimately failing the test. For example, before the fix this is what you'd see when running with this branch: (☝️ Note the This also fixes #48920 |
This was referenced Mar 15, 2023
youknowriad
approved these changes
Mar 15, 2023
It should fix them, yes. The reason they're failing is that they use branch names that need sanitizing before being used as a part of the output results filename, e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #49059
Fixes #48920
How?
Docker/
wp-envis missing the$USERenv var, which he complains about when running the perf tests locally via the CLI. For example, running./bin/plugin/cli.js perf trunk your-branchlocally will throw the following error:Sanitize the branch name before using it as a part of path or results filename.
Testing Instructions
On a Mac with Docker desktop (I don't know if it also fails in other envs):
wp-envcontainers,trunk,./bin/plugin/cli.js perf trunk fix/running-perf-tests-locallyfix/running-perf-tests-locally./bin/plugin/cli.js perf trunk fix/running-perf-tests-locallyagain,Go to the perf tests page and run the workflow manually using this branch as a base:
This will trigger the "custom comparison" step with branch names invalid as filenames, which is what breaks the release job. It should pass. See this example job that I've triggered.