Custom Classname block support: Update code comments to remove reference to anchor id #48709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
the
[Type] Code Quality
andrewserong
requested review from
apeatling,
tellthemachines and
aaronrobertshaw
|
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update code comments for the custom classname blocks support (the custom classname field under the Advanced panel in the block inspector) to remove references to anchor id. It looks like this was a copy+paste from the anchor id block support many years ago.
Why?
While reviewing #48404, I gave this block support a read and was confused for a second about the reference to anchor ids — I figured it'd be good to update the comments a tiny bit to help prevent anyone else from being confused for a second 😄
How?
Update the code comments.
Testing Instructions
Double check if the comments read okay / if I've made any spelling errors.