Lodash: Remove some _.get() from Image block
#48489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
Mamaduka,
sgomes,
aristath,
jsnajdr,
swissspidy,
glendaviesnz,
ellatrix,
flootr,
chad1008,
ntsekouras,
fabiankaegy and
brookewp
|
Size Change: +89 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
sgomes
approved these changes
Feb 27, 2023
| @@ -192,7 +192,7 @@ export function ImageEdit( { | |||
|
|
|||
| // If a caption text was meanwhile written by the user, | |||
| // make sure the text is not overwritten by empty captions. | |||
| if ( captionRef.current && ! get( mediaAttributes, [ 'caption' ] ) ) { | |||
| if ( captionRef.current && ! mediaAttributes.caption ) { | |||
There was a problem hiding this comment.
mediaAttributes is always an object.
tyxla
force-pushed
the
remove/lodash-get-image-block
branch
from
99f6993
to
59b295a
Compare
|
Flaky tests detected in 59b295a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4283463250
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Lodash's
_.get()from the Image block.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're using optional chaining instead.
Testing Instructions
Smoke test the Image block, including an existing block, testing changing, deleting, and inserting a new image, changing image sizes and additional options, and verifying everything still works well.