Fix block style preview flickering when a 'style' is focused #48418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
|
Size Change: +3 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in a8eb773. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4263318719
|
t-hamano
approved these changes
Feb 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #48320
In this PR the implementation changed to use
Popover. When we focused a button in styles through keyboard, it would move the focus to the Popover, therefore triggering theonBlurcallback. This would result in the disappearance of the style preview.This PR fixes that, by not moving the focus to the Popover.
Testing Instructions
Before
Screen.Recording.2023-02-24.at.4.22.12.PM.mov
After
Screen.Recording.2023-02-24.at.4.19.42.PM.mov