Navigation block: e2e code quality fixes #48071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaggieCabrera
added
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
|
Flaky tests detected in f54031b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4185594555
|
MaggieCabrera
force-pushed
the
e2e-fixes-nav-block
branch
from
5edbba3
to
d8bc989
Compare
|
@kevin940726 do you know what else needs to be done to add the
|
kevin940726
reviewed
Feb 15, 2023
kevin940726
reviewed
Feb 15, 2023
Co-authored-by: Kai Hao <[email protected]>
Co-authored-by: Kai Hao <[email protected]>
Co-authored-by: Kai Hao <[email protected]>
Co-authored-by: Kai Hao <[email protected]>
Co-authored-by: Kai Hao <[email protected]>
MaggieCabrera
force-pushed
the
e2e-fixes-nav-block
branch
from
dfc0e53
to
f54031b
Compare
kevin940726
approved these changes
Feb 15, 2023
There was a problem hiding this comment.
LGTM 👍 Thanks!
Note that there's already a flaky test report in #48033. We might want to take a look at that in another PR 🙂.
| editor.canvas.locator( | ||
| `role=textbox[name="Navigation link text"i] >> text="Custom link"` | ||
| ) | ||
| ).toBeVisible(); |
There was a problem hiding this comment.
Interesting that this is already reported as flaky (#48033). We might want to take a look at this test 🙂 .
There was a problem hiding this comment.
you are right, I'll have a look tomorrow!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Followup on #47867 after I missed a couple of things that were found on review after merge.
This PR also includes the
no-page-pauserule to the linter so people like me won't commit and merge pauses to their e2e tests :DTo test check that the navigation block tests pass (
npm run test:e2e:playwright -- editor/blocks/navigation.spec.js) and that you can't commit a test containingpage.pause().