LinkControl: fix scrollbar displayed on toggle link settings #47986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
changed the title
t-hamano
added
[Package] Block editor
|
Size Change: +465 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 6752cbf. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4162914625
|
getdave
approved these changes
Feb 13, 2023
Comment on lines
465
to
468
| margin-top: calc(var(--wp-admin-border-width-focus) * -1); | ||
| padding: $grid-unit-20; | ||
| padding-top: 0; | ||
| padding-top: var(--wp-admin-border-width-focus); | ||
| overflow: hidden; |
There was a problem hiding this comment.
Let's group these props together and add a comment briefly explaining why they were added and what the margin/padding stuff is all about. Feel free to drop a link to the this PR in the comment as well.
There was a problem hiding this comment.
Thanks for the review! I have added my comments, but if they are not clear, feel free to update them.
There was a problem hiding this comment.
I would like to merge this pr 👍
DaisyOlsen
added
the
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #47876
What?
This PR hides the scrollbar that appears when toggling settings in the
LinkControlcomponent. This problem occurs on Windows; Mac users may be able to reproduce it if the scrollbars are set to "Always".Why?
I think it is due to the popover content having
overflow:auto.7009058947d612f0d77a08e5dc51f3a2.mp4
How?
Applied
overflow:hidden;to the parent element of the motion element. However, this style alone will result in a cut-off focus outline:Therefore, I applied padding-top value by the width of the outline border. At the same time, a negative margin-top with the same value was applied on top to avoid changing the appearance.
Testing Instructions
Note: On Mac, you might be able to reproduce this by changing the "General > Show scroll bars" setting to "Always".
Screenshots or screencast
Before
before.mp4
After
after.mp4