Migrate Heading block tests to Playwright #47955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
requested review from
kevin940726,
ntwb,
nerrad and
ajitbohra
as code owners
Mamaduka
added
the
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 3aa1b8d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4142413898
|
|
☝️ It still reported a flaky test, is it the same issue or a new one? |
kevin940726
reviewed
Feb 10, 2023
|
It looks like a new one. The document settings aren't always open based on artifacts, so I added the step to open it before tests. Screenshot
|
kevin940726
approved these changes
Feb 10, 2023
|
Thanks for the review, @kevin940726 🙇 |
This was referenced Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851
Fixes #46984
PR migrates Heading block e2e tests to Playwright and tries to fix the flaky
should correctly apply custom colorstest.Why
While looking at test artifacts, I noticed that color validation failed after the input, and used the fallback color (black). I can only reproduce this manually when typing very slowly or fast. This would never happen in the real-world scenario since validation happens again on blur.
P.S. We might want to look into the validation issues separately.
How?
I've replaced
page.keyboard.typewithLocator.fill(), which should be closer to the paste action.Testing Instructions
Screenshots or screencast