Lodash: Remove from @wordpress/data
#47848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
Mamaduka,
sgomes,
aristath,
jsnajdr,
gziolo,
swissspidy,
flootr,
chad1008,
ntsekouras,
fabiankaegy and
brookewp
|
Size Change: +5 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 416c0dc. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4118075198
|
gziolo
reviewed
Feb 8, 2023
| @@ -608,7 +624,7 @@ function mapResolvers( resolvers, selectors, store, resolversCache ) { | |||
| * @param {Array} args Selector Arguments. | |||
| */ | |||
| async function fulfillResolver( store, resolvers, selectorName, ...args ) { | |||
| const resolver = get( resolvers, [ selectorName ] ); | |||
| const resolver = resolvers[ selectorName ]; | |||
There was a problem hiding this comment.
I hope that resolvers can only be an object based on the existing documentation. The only difference with get is that would gracefully handle different param types here.
There was a problem hiding this comment.
It will always be an object. If you trace it to its only usage, you'll notice that it's called on the result of a mapValues(), and that will generally only be an object.
gziolo
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes the last Lodash from
@wordpress/dataand removes the dependency from the package. There is just a single use in that component and conversion is pretty straightforward.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495We're aiming to reduce the bundle size of
@wordpress/datasince Lodash is over a quarter of its size. This is the last PR of that series.How?
We're using
Object.fromEntries( Object.entries().map() )as a replacement of_.mapValues()and direct access instead of_.get().Testing Instructions